Add support for cvParameters / character variant names #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would add support for the cvParameters block, that defines UI names for the cv01 to cv99 features (character variants). Accessible through
writer.characterVariantNames(andwriter.formatCharacterVariantNamesfor formatting).The names dictionary would be of the following form:
I wonder whether the
formatCharacterVariantNamesmethod should fail silently or throw an error when the value for thetypekey of the dict is not one of FeatUILabelNameID, FeatUITooltipTextNameID, SampleTextNameID or ParamUILabelNameID. Right now it just skips the name dict when it's not the case.This pull request would also update the README to reflect the changes and fix the doc for
writer.stylisticSetNamesthat was documented aswriter.stylisticSetFeatureNames.